Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(landing-page): brand NEW landing page #7550

Merged
merged 46 commits into from
Aug 26, 2024
Merged

docs(landing-page): brand NEW landing page #7550

merged 46 commits into from
Aug 26, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Aug 13, 2024 •
edited
Loading

Summary

Tasks

  • kickoff: static XL size landing page
  • i18n
  • click event
  • responsive layout: L -> M -> S
  • dark mode
  • animation (I'll ask for animation files in this step I think)
  • extract the shared components (e.g Tool Stack) to other websites (Rsbuild,Rsdoctor, etc)
// XL 1440
// L 1280
// M 834
// S 393

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: document release: document related release(mr only) label Aug 13, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9e7c506
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66cc369e308bd90008bf28e4
😎 Deploy Preview https://deploy-preview-7550--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter force-pushed the landingpage branch 3 times, most recently from cd5a408 to 9c9e620 Compare August 19, 2024 08:26
@chenjiahan chenjiahan changed the title docs(landingpage): totally NEW LandingPage docs(landing-page): brand NEW landing page Aug 20, 2024
@SoonIter
Copy link
Member Author

SoonIter commented Aug 21, 2024 •
edited
Loading

"extract the shared components"
I think rspress theme is a better choice because it is a homepage and it can be used like

---
pageType: homepage
---

@SoonIter SoonIter force-pushed the landingpage branch 2 times, most recently from bdcf97f to 57713e4 Compare August 26, 2024 02:31
@chenjiahan
Copy link
Member

I think rspress theme is a better choice because it is a homepage and it can be used like

Some sites may need to customize the page or theme, so providing components makes it easier to compose.

@SoonIter SoonIter marked this pull request as ready for review August 26, 2024 07:05
@SoonIter SoonIter requested a review from chenjiahan August 26, 2024 07:07
chenjiahan
chenjiahan requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The theme variables seems to be broken:

image

@SoonIter
Copy link
Member Author

The theme variables seems to be broken:

It is okay on my machine :D

image

@SoonIter
Copy link
Member Author

The theme variables seems to be broken:

I think it is related to css order and not my fault, lol

image image

@SoonIter SoonIter enabled auto-merge (squash) August 26, 2024 08:21
@chenjiahan
Copy link
Member

Get, I can not reproduce this theme issue too..

@SoonIter SoonIter merged commit ceb0f31 into web-infra-dev:main Aug 26, 2024
28 checks passed
@chenjiahan chenjiahan mentioned this pull request Aug 27, 2024
Merged
@SoonIter SoonIter mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
release: document release: document related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoonIter @chenjiahan